Issue Details (XML | Word | Printable)

Key: HSEARCH-346
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Juraci Paixao Krohling
Reporter: Hardy Ferentschik
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hibernate Search

Setup hudson job testing Search against several databases

Created: 06/Mar/09 11:33 AM   Updated: 06/Nov/09 04:13 AM
Component/s: engine
Affects Version/s: 3.1.0.GA
Fix Version/s: 3.2.0.Beta2

Time Tracking:
Not Specified

Issue Links:
Relates
 

Bug Testcase Reminder (view):
REMINDER: Bug reports should generally be accompanied by a test case
Participants: Emmanuel Bernard, Hardy Ferentschik and Juraci Paixao Krohling


 Description  « Hide

Bug got introduced during refactoring of DocumentBuilder. Since we are not testing against SQLServer or any other db where the generated SQL could be a problem the error passed through.
the fix is quite easy, but it is harder to write a unit test. Maybe we should try to get a proper Hudson setup instead running against multiple databases.



Hardy Ferentschik added a comment - 28/Apr/09 08:17 AM

Assigning this to Juca who can hopefully set something up in our Hudson environment. The ability to run against different databases is provided via profiles now in the POM. We basically just need a SQLServer profile for example.

It would be great to get some notifications as well, in case the build fails.


Hardy Ferentschik added a comment - 18/May/09 04:02 AM

We have a test setup now, but it needs some more investigation regarding some tests failing against some test databases. We leave this issue open for now and move it into the next release.


Emmanuel Bernard added a comment - 02/Nov/09 04:43 AM

What's the status?


Juraci Paixao Krohling added a comment - 02/Nov/09 05:02 AM

The job exists: http://hudson.qa.jboss.com/hudson/view/Hibernate%20Community/job/hibernate-search-trunk/
Not sure if it's in perfect shape though.


Juraci Paixao Krohling added a comment - 05/Nov/09 09:34 AM

Sorry, the above URL is not the public-facing Hudson. Please, check this one:
http://hudson.jboss.org/hudson/job/hibernate-search-trunk/


Hardy Ferentschik added a comment - 06/Nov/09 03:40 AM

Looks great. There seems to be a few database setups which seem to fail due to wrong user credentials or drivers. If we cannot fix them we should remove them from the setup. Here are the ones which look suspicious:

  • db2v91
  • mssql2008

I am not quite sure why postgresql824 and postgresql837 are not working. Could be that one test is not properly ending a transaction and the whole thing stands still until the job gets killed/times out.

Either way, I think after fixing/removing db2v91 and mssql2008 we can resolve this issue. The next step is to make the tests pass on all these environments. Looking at some of the tests reports a lot of problems seems to be just test setup related.


Juraci Paixao Krohling added a comment - 06/Nov/09 04:13 AM

I added the credentials to DB2 v9.1. It should work fine now. The problem with MS SQL 2008 was that it was using an old version of the driver. I updated both MS SQL 2005 and MS SQL 2008 to use the 2.0 version of the driver (as we use for DB certification in EAP side).

Regarding the jobs which are "grey" (aborted): it's probably a transaction hanging somewhere. It may be related to a problem we discussed some time ago, involving threads + integer vars to count finished threads (instead of AtomicInteger) + improper handing of exceptions. I'll check that as part of another JIRA.

If you spot any failure which may indicate a test setup problem, let me know. It should not have any problem now, as it just runs maven with the following command:

$ mvn clean install -P$database,jdbc-drivers,with-optional-jars -Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true