History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: HHH-2875
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Steve Ebersole
Reporter: Steve Ebersole
Votes: 5
Watchers: 6
Operations

If you were logged in you would be able to see more operations.
Hibernate Core

repackage cglib/asm under org.hibernate namespace

Created: 02/Oct/07 05:26 PM   Updated: 21/May/08 03:46 PM
Component/s: core
Affects Version/s: None
Fix Version/s: 3.3.0.CR2

Time Tracking:
Not Specified

Issue Links:
Fix
 


 Description  « Hide
repackage cglib+asm dependencies

 All   Comments   Work Log   Change History   FishEye      Sort Order: Ascending order - Click to sort in descending order
Travis - 10/Jan/08 09:11 PM
Is there any progress on this yet? Turns out it causes problems with JAX-RS since JAX-RS uses ASM 3. Hibernate should probably upgrade to ASM 3 too if possible.

Gail Badner - 10/Jan/08 09:51 PM
cglib 2.2 has not been released yet. When it is released, it will be upgraded.

Steve Ebersole - 22/Jan/08 10:03 AM
unscheduling from 3.2.6 since we are still waiting on said cglib release.

see original case for discussion of workaround by upgrading to a version of spring where this dependency is better encapsulated

Steve Ebersole - 22/Jan/08 10:04 AM
unscheduling from 3.2.6 since we are still waiting on said cglib release.

see original case for discussion of workaround by upgrading to a version of spring where this dependency is better encapsulated

Steve Ebersole - 20/May/08 05:06 PM
well, its now been 2 years since the last CGLIB release. I think it is safe to assume we will not be seeing a release using the new ASM APIs anytime soon. So I will go ahead and repackage cglib/asm under the org.hibernate namespace to circumvent these version conflicts. Specifically, net.sf.cglib will become org.hibernate.repackage.cglib. I will use cglib-nodeps as the basis for the repackaging (we used to use the normal cglib jar) so that asm will be properly repackaged as well.

As part of 3.3, I will also make the Javassist BytecodeProvider the default and deprecate the CGLB one (and warn on initialization).

Max Rydahl Andersen - 21/May/08 01:36 AM
Can we change this in 3.2.x ?
I've seen alot of users referring to net.sf.cglib in their code for checking lazy proxy things etc. - I know it is not fully API but im
sure users will be affected.


Steve Ebersole - 21/May/08 10:08 AM
check the fix for version ;)

yeah, that was the plan

Max Rydahl Andersen - 21/May/08 12:01 PM
maybe i was not clear ;)

I'm warning *against* doing this in 3.2 since alot of users relies on our prxies being based on sf.net.cglib....

Steve Ebersole - 21/May/08 01:05 PM
Perhaps it is better to not make that change in a point release (though users relying on 'net.sf.cglib' to detect proxies is not convincing to me)

Steve Ebersole - 21/May/08 03:46 PM
repackaging done in new maven project (org.hibernate:hibernate-cglib-repack:2.1_3) which has been uploaded to JBoss Maven Repo.

Hibernate now depends on this artifact rather than cglib:* or asm:* stuff