[#HHH-2393] Generated properties leave open ResultSet on Batcher to be closed on transaction completion

Hibernate Core

Generated properties leave open ResultSet on Batcher to be closed on transaction completion

Created: 30/Jan/07 10:42 PM Updated: 31/Jan/07 07:06 AM

Component/s:

core

Affects Version/s:

3.2.0.ga

Fix Version/s:

3.2.3

Time Tracking:

Not Specified

Issue Links:

Fix

This issue is a fix for:

~~HHH-1750~~ Exception ORA-01000 too many open cursors by generated="insert"

Description

« Hide

The patch for ~~HHH-1750~~ was not complete...

All

Comments

Work Log

Change History

FishEye

Sort Order:

[ Permalink | « Hide ]

Steve Ebersole added a comment - 30/Jan/07 10:52 PM

trunk / 3.2

[ Permalink | « Hide ]

Steve Ebersole added a comment - 31/Jan/07 07:06 AM

Further clarification...

This issue only shows up with after_statement release modes. The symptom is that the result set is kept around on the internal org.hibernate.jdbc.AbstractBatcher#resultSetsToClose queue after execution (even though it is closed). Then during org.hibernate.jdbc.ConnectionManager#afterTransaction processing, it sees the fact that the batcher still "holds a result-set" and logs a message ("forcing batcher resource cleanup on transaction completion; forgot to close ScrollableResults/Iterator?"). It then forces the batcher to close the resources (which in this case is the already closed result set).

So to be clear it is just a problem with an inappropriate log message; the result set *was not* being leaked.