Issue Details (XML | Word | Printable)

Key: HHH-2251
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Unassigned
Reporter: Max Rydahl Andersen
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Hibernate Core

Settings build unnecessary in schemaupdate/schemavalidate

Created: 17/Nov/06 12:20 PM   Updated: 17/Nov/06 12:39 PM
Component/s: None
Affects Version/s: 3.2.1
Fix Version/s: 3.2.2

Time Tracking:
Not Specified

Issue Links:
Relates
 


 Description  « Hide
the fix for HHH-2208 causes a new Settings object to be built for each table mapping when doing a schema update or validate. this is unnecessary.

in some scenarios, it might be expensive to build a new settings object because it communicates with the database for metadata and it also creates a cache provider, which might be expensive to create for clustered caches.

to fix, buildSettings (lines 947 and 1069) should be pulled out of the while loop.

 All   Comments   Work Log   Change History   FishEye      Sort Order: Ascending order - Click to sort in descending order
Max Rydahl Andersen added a comment - 17/Nov/06 12:30 PM
updated to explain severity ;(

Max Rydahl Andersen added a comment - 17/Nov/06 12:39 PM
fixed in head and 3.2.

Removed the buildSettings() completly and used the "old" way of looking up in properties.