[#HHH-1985] NodeTraverser is not SOE-safe

Hibernate Core

NodeTraverser is not SOE-safe

Created: 08/Aug/06 06:52 AM Updated: 19/Mar/09 08:33 AM

Component/s:

core

Affects Version/s:

3.2.0.cr3

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

patch.txt (2 kB)

Issue Links:

Duplicate

This issue duplicates:

HHH-2166 Long "in" lists in queries results in a Java stack overflow exception.

Description

« Hide

org.hibernate.hql.ast.util.NodeTraverser
It is possible for java.lang.StackOverflowError to occur in NodeTraverser.java:41;42 with very deep tree. Need another algorith to visit whole tree.

08.08 19:50:09 ERROR [ArpSiteServlet] Servlet.service() for servlet ArpSiteServlet threw exception
java.lang.StackOverflowError
        at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:41)
        at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:41)
        at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
        at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
        at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
        at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)

All

Comments

Work Log

Change History

FishEye

Sort Order:

[ Permalink | « Hide ]

Max Rydahl Andersen added a comment - 08/Aug/06 06:59 AM

test case please

[ Permalink | « Hide ]

Sergey Vladimirov added a comment - 08/Aug/06 07:04 AM

SELECT objects FROM Object objects WHERE id in (1, 2, 3, ..., ..., 100000)

[ Permalink | « Hide ]

Sergey Vladimirov added a comment - 08/Aug/06 07:05 AM

Sorry, not DEEP tree, but WIDE tree.

[ Permalink | « Hide ]

Sergey Vladimirov added a comment - 08/Aug/06 07:14 AM

Patch

[ Permalink | « Hide ]

Anders Wallgren added a comment - 02/May/08 05:08 PM

Any reason why this patch has been lingering for so long?

[ Permalink | « Hide ]

Geoffrey De Smet added a comment - 23/Dec/08 08:09 AM

Encountered this bug in hibernate-core 3.3.1.GA
Strange this is that it doesn't occuring during debugging.

[ Permalink | « Hide ]

Laurent Delaforge added a comment - 19/Mar/09 08:33 AM

I don't understand why this issue is a "Minor Improvement" while the duplicate issue HHH-2166 is a "Major Bug".
It would be a good idea to blend the duplicate.

In my humble opinion it is a bug, not an improvement.
Minor or major, I am not able to say