Issue Details (XML | Word | Printable)

Key: HHH-1103
Type: Patch Patch
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Gavin King
Reporter: Juozas Baliuka
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hibernate Core

finalize method filter for proxies

Created: 27/Oct/05 02:11 AM   Updated: 27/Oct/05 07:03 AM   Resolved: 27/Oct/05 07:03 AM
Component/s: None
Affects Version/s: 3.0 alpha, 3.0 beta 1, 3.0 beta 2, 3.0 beta 3, 3.0 beta 4, 3.0 rc 1, 3.0 final, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.1 beta 1, 3.1 beta 2, 3.1 rc 1, 3.1 rc2, 3.1 rc3, 3.1.1, 3.1.2, 3.2.0.alpha1
Fix Version/s: 3.1 rc3

Time Tracking:
Not Specified

File Attachments: 1. Text File patch.txt (3 kB)
2. Text File test-patch.txt (2 kB)

Environment: Any

Patch Reminder (view):
REMINDER: Patches should be in 'svn diff' format; see details
Participants: Gavin King, Juozas Baliuka and Max Rydahl Andersen


 Description  « Hide

This proxy factory doe's not owrride "finalize" method, it must improve proxy garbage collection.



Max Rydahl Andersen added a comment - 27/Oct/05 02:15 AM

what if the underlying object class actually have finalize defined ? is there a way to expose that ?


Juozas Baliuka added a comment - 27/Oct/05 03:15 AM

Intercptor handles "finalize" method this way:

if ( "finalize".equals(methodName) ) {
return null; // NoOp
}

GC will call "finalize" if user owerrides it, we do not need to delegate this method. And probably it is wrong to delegate "finalize".


Max Rydahl Andersen added a comment - 27/Oct/05 03:35 AM

ah of course ....ok well apply this asap...would be nice to measure the effects of it.


Max Rydahl Andersen added a comment - 27/Oct/05 03:36 AM

well = we will


Gavin King added a comment - 27/Oct/05 07:03 AM

Thanks, I applied the patch.