[#EJB-284] Scanning for META-INF/orm.xml does not work on Windows in EE mode - Hibernate JIRA

z - Hibernate Entity Manager

Scanning for META-INF/orm.xml does not work on Windows in EE mode

Created: 01/Apr/07 10:15 PM Updated: 03/Jul/07 03:32 AM Resolved: 03/Jul/07 03:32 AM

Component/s:

EntityManager

Affects Version/s:

3.3.1.GA

Fix Version/s:

3.3.2.Beta1

Time Tracking:

Not Specified

File Attachments:

petclinic.log.bz2 (4 kB)
2.

petclinic.z01 (5.86 MB)
3.

petclinic.zip (4.27 MB)
4.

SeparatorTest.java (0.7 kB)

Environment:

« Hide

Windows XP SP2
Tomcat 5.2.23
Spring 2.0.3
Hibernate Core 3.2.2.GA
Hibernate Annotations 3.3.0.GA
Hibernate EntityManager 3.3.1.GA

Issue Links:

Fix

This issue is fixed by:

~~EJB-302~~ Move away from ArchiveBrowser and use JarVisitor

Bug Testcase Reminder (view):
REMINDER: Bug reports should generally be accompanied by a test case
Participants:	Christian Bauer, Emmanuel Bernard and Gary Ip

Description

« Hide

org.hibernate.ejb.Ejb3Configuration: line: 606, method scanForXmlFiles(...),

Iterator it = ArchiveBrowser.getBrowser(
jar, new ArchiveBrowser.Filter() {
public boolean accept(String filename) { return (searchforHBMFiles && filename.endsWith( ".hbm.xml" ) ) || (searchforORMFiles && filename.endsWith( META_INF_ORM_XML ) ) ; }
}

filename passed in use "/" in *NIX environment, while "\" is used in Win32 environment. So orm.xml will be ignored in Win32 environment, as it will end with META-INF\orm.xml and won't be matched.

Sort Order:

[ Permalink | « Hide ]

Emmanuel Bernard added a comment - 09/Apr/07 08:20 AM

Can you provide a runnable test case? The path should be normalized before so such problem should not appear

[ Permalink | « Hide ]

Gary Ip added a comment - 09/Apr/07 10:10 AM

You may need Spring 2.0.4 latest snapshot, as I tested with the hsqldb comes with Spring petclinic example.

Test environment:
Windows XP SP2
Tomcat 5.2.23

P.S. I have split the war file into two zip files, as JIRA restrict the upload size to 10MB.

[ Permalink | « Hide ]

Christian Bauer added a comment - 09/Apr/07 11:19 AM

Please attach a standalone testcase without Spring, WAR, etc.

[ Permalink | « Hide ]

Emmanuel Bernard added a comment - 09/Apr/07 06:03 PM

Hum, I suspect this is a bug related to how Spring treats URLs and propagate them to JPA.
can you set your logs to debug and report the log starting with
Processing PersistenceUnitInfo [

AFAIK an URL should not use \ unless it's encoded. And certainly it should not be considered a separator.

[ Permalink | « Hide ]

Gary Ip added a comment - 09/Apr/07 08:44 PM

A small Java program that simple prints all files searched from "file:///". It shows filename are using "\" rather than "/".

Tested with jboss-archive-browsing.jar that comes with HEM 3.3.1.GA.

[ Permalink | « Hide ]

Gary Ip added a comment - 09/Apr/07 09:09 PM

Here attached the log file as requested.

[ Permalink | « Hide ]

Emmanuel Bernard added a comment - 11/Apr/07 02:27 PM

Yes but the spec states that URL should be returned, not File objects

[ Permalink | « Hide ]

Emmanuel Bernard added a comment - 11/Apr/07 03:04 PM

OK the bug is in ArchiveBrowser, they actually do not abstract the path. Luckily for him, Bill is a thousand miles away from me at the moment.

i plan to get rid of ArchiveBrowser completly and use JarVisitor which has been more thoroughly tested.

[ Permalink | « Hide ]

Emmanuel Bernard added a comment - 02/Jul/07 07:36 AM

Hi Gary, can you give SVN head a try?
http://anonsvn.jboss.org/repos/hibernate/trunk/HibernateExt/

I've reworked the way archives are parsed (~~EJB-302~~). It should work fine now. I can't test on windows though